shlomiken commented on PR #26944:
URL: https://github.com/apache/airflow/pull/26944#issuecomment-1842494020

   @potiuk - looks like this PR breaks get_first and get_records return type 
for snowflake for example , so instead of tuple we get a Dict.
   this also breaks SqlSensor 
   
   this code - was getting the default cursor from the connection 
(`SnowFlakeCursor`) - but now is in the hands of the specific hook  , which in 
snowflake case return a `DictCursor`
   
   ```
    with closing(conn.cursor()) as cur:
                   results = []
                   for sql_statement in sql:
                       self._run_command(cur, sql_statement, parameters)
   
                       if handler is not None:
                           result = handler(cur)
                           results.append(result)
     ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to