uranusjr commented on code in PR #36085:
URL: https://github.com/apache/airflow/pull/36085#discussion_r1417027820
##########
airflow/providers/weaviate/hooks/weaviate.py:
##########
@@ -135,22 +139,40 @@ def create_schema(self, schema_json: dict[str, Any]) ->
None:
client = self.conn
client.schema.create(schema_json)
+ @staticmethod
+ def check_http_error_is_retryable(exc: BaseException):
Review Comment:
```suggestion
def check_http_error_should_retry(exc: BaseException):
```
The `not exc.response.ok` part makes the “retryable” part not accurate
(technically an OK response is still retryable?)
##########
airflow/providers/weaviate/hooks/weaviate.py:
##########
@@ -135,22 +139,40 @@ def create_schema(self, schema_json: dict[str, Any]) ->
None:
client = self.conn
client.schema.create(schema_json)
+ @staticmethod
+ def check_http_error_is_retryable(exc: BaseException):
Review Comment:
```suggestion
def check_http_error_should_retry(exc: BaseException):
```
The `not exc.response.ok` part makes the “retryable” part not accurate
(technically an OK response is still retryable?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
