potiuk commented on PR #36084: URL: https://github.com/apache/airflow/pull/36084#issuecomment-1842714520
Longer explanation: > I'm not sure why mypy fails now - it looks the opposite to what happens in main. Yes. This is entirely expected that your PR will have 'regular' constraints. Only the `main` build (also known as `canary` will attempt to upgrade dependencies to the newer ones. For 'regular` PRs the PR are using 'frozen' constraints which are automatically updated by the latest main build that passed all tests. This way when there is a change in released packages) - such as this one - all the regular PRs that do not touch dependencies will run using 'good' versions of packages. This is all as designed as expected - this way change like this only fails canary build and a handful of PRs that change dependencies, but all 'standard' PRs are unaffected. So yes - your PR uses the 'previous' version of openlineage libs - so you have to make your fix in the way that it is backwards compatible - and works for both - whAt was before the change and after. This is precisely what our users will have - some of them will use previous version of open lineage and some use the new version. If you want to make a change that only works for newer version (which I think is not the case here) then you also have to update requirements for open lineage provider (and add >= x.y.z for example). This way your PR will be 'changing' dependencies which means that it will automatically use 'upgrade to newer' This is all precisely as designed and expected :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
