Joffreybvn commented on PR #35591: URL: https://github.com/apache/airflow/pull/35591#issuecomment-1843715351
Makes total sense ! I added a `AIRFLOW__HTTP__EXTRA_AUTH_TYPES` parameter for the Airflow 'Deployment manager' to control which classes can be set as `"auth_type"`. By default, only classes from `requests.auth` and the ones added via this parameter can be used. If any other class is setup, the following message will appear in the logs, when executing the task:  --- To continue, I guess I'll have to revert [this commit](https://github.com/apache/airflow/pull/35591/commits/755d013fbb0bd8d85be5dd96fe35d8c9dbeef1ad), but I pushed it anyway because at worst we get a nice discussion: Here I refactor the UI of the Http Connection: _- yes I'll fix the CSS/styling if this got some approval_  Where the user can select an authentication class from the ones available:  In term of breaking changes: The "Extra" field is not visible anymore. Its content should move to the new "Extra Headers" section. - Is that acceptable ? - Maybe with a migration script ? For user with default Secret backend, each http connection can be 'upgraded' to this new schema - Maybe by keeping the "Extra" field visible, with a deprecation message. And in few releases, it disappears ? Hooks dependent of the `HttpHook` (like the LivyHook) are not impacted - _which I don't understand why, I'd expect subclasses to get parent's extra fields_. @potiuk What do you think ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
