nuclearpinguin commented on a change in pull request #5845: [AIRFLOW-5158] adds google sheets hook URL: https://github.com/apache/airflow/pull/5845#discussion_r314954988
########## File path: tests/contrib/hooks/test_gcp_sheets_hook.py ########## @@ -0,0 +1,166 @@ +# -*- coding: utf-8 -*- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# +""" +This test script tests GCPSheetsHook on a live Google sheet, to do so: Review comment: @milton0825 is right, unit testes would be great. Please take a look at GCP Natural Language or Compute hooks. If you would like to perform system test then we have a nice framework for it where you define an example DAG and you run it as a test with SetUp and TearDown if necessary. It has the advantage of providing users with an example ;) For example: https://github.com/PolideaInternal/airflow/blob/feature/big-query-dts-operators/tests/gcp/operators/test_bigquery_dts_system.py https://github.com/PolideaInternal/airflow/blob/feature/big-query-dts-operators/airflow/gcp/example_dags/example_bigquery_dts.py ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
