kimyen commented on code in PR #36078:
URL: https://github.com/apache/airflow/pull/36078#discussion_r1422701491
##########
tests/integration/executors/test_celery_executor.py:
##########
@@ -146,6 +147,9 @@ def fake_execute_command(command):
executor._process_tasks(task_tuples_to_send)
+ # allow some time for the task to be processed
+ time.sleep(10)
Review Comment:
This is my first attempt to fix an unrelated test. From the previous failed
test
[result](https://github.com/apache/airflow/actions/runs/7110348879/job/19356772387),
it looks like:
- There are 2 items were sent to the queue
- The assert found 1 item while expecting 2 items
- The item that was found was sent first
- The test is marked as flaky with 3 retries
My logic is that some tests were ran on VMs with lower bandwidth and hence
the second item has not come up. In the first attempt, I want to give high
number of second wait to ensure that the items show up when assert statement is
executed. This is to remove this PR as a victim of an flaky test.
I have not gone back to run a bunch of test to verify the efficient number
of seconds to wait here. This is because it's time consuming and cost resources
as each commit I make will trigger the entire CI suite to run. I hoped that by
the time someone review my code, someone else already fix this test.
Please give me guidance on whether or not I should include this fix in this
PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
