dstandish commented on code in PR #28900:
URL: https://github.com/apache/airflow/pull/28900#discussion_r1423410165
##########
airflow/models/dag.py:
##########
@@ -1383,8 +1384,43 @@ def normalized_schedule_interval(self) ->
ScheduleInterval:
_schedule_interval = self.schedule_interval
return _schedule_interval
+ @staticmethod
+ @internal_api_call
@provide_session
- def handle_callback(self, dagrun, success=True, reason=None,
session=NEW_SESSION):
+ def fetch_callback(
Review Comment:
@vincbeck @potiuk @mhenc @uranusjr just curious what your thoughts are on
backward compatibility on this one. technically it (`handle_callback`) was
part of a public class and not marked `:meta private:` in the docstring so....
technically it was probably public and therefore subject to backcompat.
that said, considering it as part of the public API also seems absurd. do
you think we should put in our "public API" some "cover your ass" type of
language that sort of expresses that .... methods which are clearly not for
public use, even if not marked internal, are internal. maybe we could add some
language that explains what that means. like methods not related to the dag
authoring interface etc -- not sure.
but in any case, we should mark `fetch_callback` as private by either
prefixing with underscore or adding `:meta private:`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
