potiuk commented on PR #907: URL: https://github.com/apache/airflow-site/pull/907#issuecomment-1852591497
> That means modifying pre-commit and enabling 2.5.0 back Does it? I think we do not do any pre-commit that would prevent dask executor to keep 2.5.0 (but maybe I am wrong and we need to FIX a pre-commit in question to allow it for removed providers). > Why do you feel strongly about it? what is the down side? Because the only reason for releasing the package is that we want the `pypi` description to change to signal that it has been removed. I do not feel super-strong about it, but at least my vision for it that the package should be exactly the same as before - with the only difference being description. Just to avoid any potential issues, I thought about it "let's not change anything in the package at all". Bumping min-version only makes sanse when we want to have some future changes there to make people "want" to upgrade to newer version of Airflow. In case of removed provider - this motivation for bumping min-airflow version is gone (because there are no new features, and will not be new features any more) so bumping min-airflow version in this case is nothing else than "cargo cult" - we will do it because we generally do it for other packages, without the actualy reason for doing it. I cannot think of particular scenario where it would be problematic, but I think there is simply absolutely no reason do it. And I very much don't like we do anything unless we have a good reason for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
