Joffreybvn commented on code in PR #36205:
URL: https://github.com/apache/airflow/pull/36205#discussion_r1425894982
##########
airflow/providers/databricks/hooks/databricks_sql.py:
##########
@@ -243,11 +244,15 @@ def run(
@staticmethod
def _make_serializable(result):
- """Transform the databricks Row objects into JSON-serializable
lists."""
+ """Transform the databricks Row objects into JSON-serializable
namedtuple."""
+ columns: list[str] | None = None
if isinstance(result, list):
- return [list(row) for row in result]
+ columns = result[0].__fields__
+ row_object = namedtuple("Row", columns)
Review Comment:
I put the serializable namedtuple behind a `return_serializable` flag, which
is False by default. With a warning for a future release of the provider, where
it would turn to True by default. And eventually later the flag can disappear
too to only return the namedtuple.
What do you think ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
