Joffreybvn commented on code in PR #36205:
URL: https://github.com/apache/airflow/pull/36205#discussion_r1427221843
##########
airflow/providers/databricks/hooks/databricks_sql.py:
##########
@@ -80,8 +85,18 @@ def __init__(
self.http_headers = http_headers
self.catalog = catalog
self.schema = schema
+ self.return_serializable = return_serializable
self.additional_params = kwargs
+ if not self.return_serializable:
Review Comment:
Yes, this is to ensure the change is backward compatible.
Users of the hook will be warned. Users of the `DatabricksSqlOperator`
won't, because the operator was already returning a list of tuple - which
becomes a list of namedtuple with this PR. Thus, it will generate noise only to
hook users.
The goal is to effectively do a breaking change later. But if we don't want
that - or not _that_ soon, I can check to print the warning only when the
provider loads ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
