eladkal commented on code in PR #36179: URL: https://github.com/apache/airflow/pull/36179#discussion_r1428347485
########## airflow/providers/amazon/aws/utils/exponential_backoff_retry.py: ########## @@ -0,0 +1,60 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +import logging +from datetime import datetime, timedelta +from typing import Callable + +from airflow.utils import timezone + +log = logging.getLogger(__name__) + + +def exponential_backoff_retry( Review Comment: We use retry backoff in core code https://github.com/apache/airflow/blob/f60d458dc08a5d5fbe5903fffca8f7b03009f49a/airflow/models/taskinstance.py#L1992 It's not quite the same but I wonder if we want to maintain two backoff retry logics? Can we maybe have util logic for backoff retry to be shared by both core and providers? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
