shubham22 commented on code in PR #36250:
URL: https://github.com/apache/airflow/pull/36250#discussion_r1428627753
##########
airflow/config_templates/config.yml:
##########
@@ -944,6 +944,14 @@ metrics:
description: |
StatsD (https://github.com/etsy/statsd) integration settings.
options:
+ metrics_use_fuzzy_match:
Review Comment:
I am personally against adding a new config for `metrics_use_fuzzy_match`.
With this approach, we will keep sprawling the number of configurations every
time we need to make a hard decision. I am of the opinion that we should have
just 2 configs - `metrics_allow_list` and `metrics_block_list` - and they
should be changed to support the pattern matching. That means, we should
deprecate existing configs now and introduce new ones which are more powerful
and support pattern matching, in order to keep it backward compatible. Yes,
this means we need to go through deprecation until v3.0, but I think that is
better for the product.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
