hussein-awala commented on code in PR #35633:
URL: https://github.com/apache/airflow/pull/35633#discussion_r1393074974


##########
chart/values.schema.json:
##########
@@ -6086,6 +6086,11 @@
                     "x-docsSection": "PgBouncer",
                     "additionalProperties": false,
                     "properties": {
+                        "enabled": {
+                            "description": "Enable PgBouncer metric exporter 
sidecar.",
+                            "type": "boolean",
+                            "default": false

Review Comment:
   +1



##########
chart/values.yaml:
##########
@@ -2030,6 +2030,7 @@ pgbouncer:
         command: ["/bin/sh", "-c", "killall -INT pgbouncer && sleep 120"]
 
   metricsExporterSidecar:
+    enabled: false

Review Comment:
   Definitely, default value should be true to keep it b/c.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to