hussein-awala commented on code in PR #36167:
URL: https://github.com/apache/airflow/pull/36167#discussion_r1428977552


##########
chart/templates/_helpers.yaml:
##########
@@ -84,7 +84,7 @@ If release name contains chart name it will be used as a full 
name.
         name: {{ template "airflow_metadata_secret" . }}
         key: connection
   {{- end }}
-  {{- if and .Values.workers.keda.enabled .Values.pgbouncer.enabled (not 
.Values.workers.keda.usePgbouncer) }}
+  {{- if (or (and .Values.workers.keda.enabled (eq 
.Values.data.metadataConnection.protocol "mysql")) (and 
.Values.workers.keda.enabled .Values.pgbouncer.enabled (not 
.Values.workers.keda.usePgbouncer))) }}

Review Comment:
   This could be simplified to:
   ```suggestion
     {{- if and .Values.workers.keda.enabled (or (eq 
.Values.data.metadataConnection.protocol "mysql") (and 
.Values.pgbouncer.enabled (not .Values.workers.keda.usePgbouncer))) }}
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to