[
https://issues.apache.org/jira/browse/AIRFLOW-5246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16909982#comment-16909982
]
ASF GitHub Bot commented on AIRFLOW-5246:
-----------------------------------------
potiuk commented on pull request #5854: [AIRFLOW-5246] Remove source parameter
in BaseHook constructor
URL: https://github.com/apache/airflow/pull/5854
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-5246
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
### Code Quality
- [x] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove unused source constructor parameter in BaseHook
> ------------------------------------------------------
>
> Key: AIRFLOW-5246
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5246
> Project: Apache Airflow
> Issue Type: Improvement
> Components: core
> Affects Versions: 2.0.0
> Reporter: Jarek Potiuk
> Priority: Major
>
> The Base Hook constructor has source parameter which is unused. There are a
> few hooks that still pass it but the value is discarded.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
