spencertollefson opened a new pull request, #36273:
URL: https://github.com/apache/airflow/pull/36273
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
closes: #34794
This PR modifys the SQLCheckOperator's behaviour in how it handles reading a
Python `dict`.
Previously, if a Python `dict` was returned by the SQL query, the
SQLCheckOperator would always pass. As suggested in the linked issue, if a
Python `dict` is returned it is recommended that if any of the dict's values
are False-y , then the Operator should fail. This PR makes that change.
For example, if the SQL query being tested returns:
```sql
{'DUPLICATE_ID_CHECK': False, 'NULL_VALUES_CHECK': True}
```
then the operator should return False, since there is a Falsy value present.
The PR also adds an additional unit test and updated the documentation of
the Operator.
**Question for reviewers**: I am concerned that users may be implementing
this operator under the assumption that any `dict` returned means the task
should pass. With this change, that would now lead to the task failing.
---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
