potiuk commented on code in PR #36205:
URL: https://github.com/apache/airflow/pull/36205#discussion_r1430139613
##########
airflow/providers/odbc/hooks/odbc.py:
##########
@@ -212,17 +216,27 @@ def get_sqlalchemy_connection(
cnx = engine.connect(**(connect_kwargs or {}))
return cnx
- @staticmethod
- def _make_serializable(result: list[pyodbc.Row] | pyodbc.Row | None) ->
list[NamedTuple] | None:
- """Transform the pyodbc.Row objects returned from an SQL command into
JSON-serializable NamedTuple."""
+ def _make_serializable(self, result: Any) -> Any:
Review Comment:
Actually what we would have to do, to not yank the current odbc provider is
to add code in the common.sql to check if it's there and call it. Adding it
here while we also add >= 1.9.1 on the common.sql makes no sense (because 1.9.1
will never call it)
The back-compatibilty here is to let the "just released" odbc provider to
work with the new `"common.sql" - not the other way round.
But maybe better - just remove it and I will simply yank the odbc provider
we just released, it's going to be way simpler @Joffreybvn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
