Taragolis commented on code in PR #36281:
URL: https://github.com/apache/airflow/pull/36281#discussion_r1430555265
##########
tests/cli/commands/test_dag_command.py:
##########
@@ -161,7 +161,7 @@ def test_backfill(self, mock_run):
)
output = stdout.getvalue()
- assert f"Dry run of DAG example_bash_operator on
{DEFAULT_DATE.isoformat()}\n" in output
+ assert f"Dry run of DAG example_bash_operator on
{DEFAULT_DATE.isoformat(sep=' ')}\n" in output
Review Comment:
Because `penudlum.DateTime` now have less overwrite on `datetime.datetime`
it change the behaviour of convert to string
**Pendulum 2**
```python
>>> import pendulum
>>> str(pendulum.now())
'2023-12-18T23:14:57.788852+04:00'
```
**Pendulum 3**
```python
>>> import pendulum
>>> str(pendulum.now())
'2023-12-18 23:14:57.788852+04:00'
```
##########
tests/api_connexion/endpoints/test_dag_endpoint.py:
##########
@@ -418,7 +418,7 @@ def test_should_response_200_for_null_start_date(self,
url_safe_serializer):
"tags": [],
"template_searchpath": None,
"timetable_description": None,
- "timezone": "Timezone('UTC')",
+ "timezone": "UTC",
Review Comment:
Well, change in default type for UTC change API response and instead of
__repr__ it starts return Timezone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]