Lee-W commented on code in PR #36303:
URL: https://github.com/apache/airflow/pull/36303#discussion_r1431561273
##########
airflow/providers/ssh/operators/ssh.py:
##########
@@ -156,6 +167,8 @@ def raise_for_status(self, exit_status: int, stderr: bytes,
context=None) -> Non
if context and self.do_xcom_push:
ti = context.get("task_instance")
ti.xcom_push(key="ssh_exit", value=exit_status)
+ if self.skip_on_exit_code is not None and exit_status in
self.skip_on_exit_code:
+ raise AirflowSkipException(f"SSH command returned exit code
{self.skip_on_exit_code}. Skipping.")
Review Comment:
```suggestion
raise AirflowSkipException(f"SSH command returned exit code
{exit_status}. Skipping.")
```
I think we might want to log the raised exit code instead of the allowed
exit code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
