dominikhei opened a new pull request, #36347:
URL: https://github.com/apache/airflow/pull/36347
related: #36128
The contained changes are only a first working draft, since I want to
discuss how to approach some of the following issues. So far only the ``airflow
roles export`` command is changed, I will adjust the ``airflow roles import``
command after having discussed the following issues and will request a
re-review.
The export command now exports resources and actions by default in the
following structure:
```
[{"name": "FakeTeamA", "resource": "Pools", "action": "can_edit,can_read"},
{"name": "FakeTeamA", "resource": "Pools", "action": ",can_read"},
{"name": "FakeTeamB", "resource": "", "action": ""}]
```
- When a role has no permissions the values for the respective keys are set
to empty Strings.
This way the import function can later easily distinguish if the imported
role needs permissions to be set or not
- @potiuk I originally mentioned that we could use the ``-p`` flag to say
whether we want to export names and permissions or just the names. However the
function already uses the ``-p`` flag (--pretty) thus I believe this will not
work. That's why the function currently also exports permissions by default.
- Previously the ``-p`` flag sorted the list of names in alphabetical order
and set the indent to 4 . However with the function now returning a list of
dictionaries, I disabled the sorting if ``-p``is set, because in this case the
order of the keys would be switched.
Regarding the ``airflow roles import`` command: How should I approach the
case when one of the imported roles already
exists in the database? Should we skip this role and keep the original one
with its permissions or overwrite it with the new one and its permissions?
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
