aliotta commented on code in PR #36329:
URL: https://github.com/apache/airflow/pull/36329#discussion_r1434383648


##########
docs/apache-airflow-providers-fab/auth-manager/access-control.rst:
##########
@@ -228,19 +241,50 @@ Toggle DAG paused status               DAGs.can_edit
 Show Gantt Chart                       DAGs.can_read, Task Instances.can_read  
                                Viewer
 Get external links                     DAGs.can_read, Task Instances.can_read  
                                Viewer
 Show Task Instances                    DAGs.can_read, Task Instances.can_read  
                                Viewer
+Show Configurations menu               Configurations.menu_access              
                                Op
 Show Configs                           Configurations.can_read                 
                                Viewer
 Delete multiple records                DAGs.can_edit                           
                                User
 Set Task Instance as running           DAGs.can_edit                           
                                User
 Set Task Instance as failed            DAGs.can_edit                           
                                User
 Set Task Instance as success           DAGs.can_edit                           
                                User
 Set Task Instance as up_for_retry      DAGs.can_edit                           
                                User
 Autocomplete                           DAGs.can_read                           
                                Viewer
+Show Dataset menu                      Datasets.menu_access                    
                                Viewer
+Show Datasets                          Datasets.can_read                       
                                Viewer
+Show Docs menu                         Docs.menu_access                        
                                Viewer
+Show Documentation menu                Documentation.menu_access               
                                Viewer
+Show Jobs menu                         Jobs.menu_access                        
                                Viewer
+Show Audit Log                         Audit Logs.menu_access                  
                                Viewer
+Reset Password                         My Password.can_read, My 
Password.can_edit                              Viewer                      
Viewer

Review Comment:
   I think you have one too many "Viewer" here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to