potiuk commented on code in PR #36361:
URL: https://github.com/apache/airflow/pull/36361#discussion_r1435272061
##########
tests/operators/test_python.py:
##########
@@ -847,31 +847,41 @@ def test_virtualenv_serializable_context_fields(self,
create_task_instance):
assert set(context) == declared_keys
@pytest.mark.parametrize(
- "extra_kwargs, actual_exit_code, expected_state",
+ "kwargs, actual_exit_code, expected_state",
[
- (None, 99, TaskInstanceState.FAILED),
+ ({}, 0, TaskInstanceState.SUCCESS),
+ ({}, 100, TaskInstanceState.FAILED),
+ ({}, 101, TaskInstanceState.FAILED),
+ ({"skip_on_exit_code": None}, 0, TaskInstanceState.SUCCESS),
+ ({"skip_on_exit_code": None}, 100, TaskInstanceState.FAILED),
+ ({"skip_on_exit_code": None}, 101, TaskInstanceState.FAILED),
+ ({"skip_on_exit_code": 100}, 0, TaskInstanceState.SUCCESS),
({"skip_on_exit_code": 100}, 100, TaskInstanceState.SKIPPED),
- ({"skip_on_exit_code": [100]}, 100, TaskInstanceState.SKIPPED),
- ({"skip_on_exit_code": (100, 101)}, 100,
TaskInstanceState.SKIPPED),
({"skip_on_exit_code": 100}, 101, TaskInstanceState.FAILED),
+ ({"skip_on_exit_code": 0}, 0, TaskInstanceState.SKIPPED),
Review Comment:
Fix here: https://github.com/apache/airflow/pull/36372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
