hussein-awala commented on code in PR #36365:
URL: https://github.com/apache/airflow/pull/36365#discussion_r1435383000


##########
helm_tests/airflow_aux/test_basic_helm_chart.py:
##########
@@ -644,6 +645,7 @@ def test_priority_classes_default_preemption(self):
         )[0]
 
         assert obj["preemptionPolicy"] == "PreemptLowerPriority"
+        assert obj["description"] == 'This priority class will not cause other 
pods to be preempted.'

Review Comment:
   ```suggestion
           assert obj["description"] == "This priority class will not cause 
other pods to be preempted."
   ```



##########
helm_tests/airflow_aux/test_basic_helm_chart.py:
##########
@@ -631,6 +631,7 @@ def test_priority_classes(self):
             assert objs[i]["metadata"]["name"] == ("my-release" + "-" + 
pc[i]["name"])
             assert objs[i]["preemptionPolicy"] == pc[i]["preemptionPolicy"]
             assert objs[i]["value"] == pc[i]["value"]
+            assert objs[i]["description"] == 'This priority class will not 
cause other pods to be preempted.'

Review Comment:
   ```suggestion
               assert objs[i]["description"] == "This priority class will not 
cause other pods to be preempted."
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to