Taragolis commented on code in PR #36391:
URL: https://github.com/apache/airflow/pull/36391#discussion_r1435642835


##########
airflow/providers/fab/provider.yaml:
##########
@@ -25,6 +25,11 @@ description: |
   `Flask App Builder <https://flask-appbuilder.readthedocs.io/>`__
 
 suspended: false
+
+# The provider is not yet ready to be released, we will skip it by default 
when preparing new release waves
+# For providers until we think it should be released.
+not-ready: true

Review Comment:
   I think we might be close to replace all states attributes by a single as 
enum (as follow up), e.g.:
   ```json
   "state": {
           "type": "string",
           "enum": ["ready", "not-ready", "suspended", "removed"]
         },
   ```
   I think all states are mutually exclusive and lifecycle for abstract package 
would be
   
   ```mermaid
   graph TD;
       not-ready-->ready;
       ready-> not-ready;l
       ready-->suspended;
       ready-->removed;
       suspended-->removed;
   ```



##########
airflow/providers/fab/provider.yaml:
##########
@@ -25,6 +25,11 @@ description: |
   `Flask App Builder <https://flask-appbuilder.readthedocs.io/>`__
 
 suspended: false
+
+# The provider is not yet ready to be released, we will skip it by default 
when preparing new release waves
+# For providers until we think it should be released.
+not-ready: true

Review Comment:
   I think we might be close to replace all states attributes by a single as 
enum (as follow up), e.g.:
   ```json
   "state": {
           "type": "string",
           "enum": ["ready", "not-ready", "suspended", "removed"]
         },
   ```
   I think all states are mutually exclusive and lifecycle for abstract package 
would be
   
   ```mermaid
   graph TD;
       not-ready-->ready;
       ready-> not-ready;
       ready-->suspended;
       ready-->removed;
       suspended-->removed;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to