hussein-awala commented on PR #36374: URL: https://github.com/apache/airflow/pull/36374#issuecomment-1868617680
The mentioned issue mentions #30264 as a potential use case, but this PR will not close it, because the running tasks are marked as skipped without raising any skip exception: https://github.com/apache/airflow/blob/c7e13061bd472962ed571cb0d33784900217660a/airflow/jobs/scheduler_job_runner.py#L1449-L1464 So IMHO, if you want to split implementing the callback on different PRs, you need to update the description by replacing: ```md closes: #35936 ``` by ```md related: #35936 ``` of course, with clarifying that in the doc as @eladkal suggested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
