coopergillan commented on issue #5841: [AIRFLOW-3705] Fix PostgresHook get_conn 
to use conn_name_attr
URL: https://github.com/apache/airflow/pull/5841#issuecomment-522752383
 
 
   @ashb - I see your point. This looked like a bug to us when we sub-classed 
the Hook to connect to a Redshift instance. We set `conn_name_attr` to 
`redshift_conn_id`, but this made it impossible to use `get_conn`.
   
   I'm working on your suggestion in my own code and have not yet gotten my own 
tests to pass, but I can keep trying.
   
   I think I'm seeing now that this attribute really isn't meant to be changed 
and is really more for the entire hook class, correct?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to