potiuk opened a new pull request, #36472:
URL: https://github.com/apache/airflow/pull/36472
While applying result of the discussion about "resolving conversation" I
have found that it would be good - while enabling it to test it to describe a
bit better and explain some of the things we learned and "practice" for our
PRs, so that we can easily refer to it when contributors ask us what to expect
when they opened a PR.
This change introduces the following:
* explains the contributors what they can expect during PR review
* explains what expectations we have for such PRs and what is the role of
author in fulfilling the expectations and following up
* explain how to treat conversations and how using conversations and
expecting them to be resolved is a sign of trust
* explains that we experimentally enable the "resolve conversation"
requirement and why we are doing it, and what we expect to get from it
* adds a few PR guidelines that we often discuss and explain to the
contributors but we did not have them written down.
* cleans up protected_branches configuration in the .asf.yaml and enables
"resolve conversation" requirement for `main` branch
* it also adds "linear history" requirement for all our `main` and `stable`
brances - that was implicitly protected also by our merge policies, but
enabling it explicitly is better protection for case where someone would enable
"merge" approach temporarily for other branches (maybe).
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
