Taragolis commented on PR #36469:
URL: https://github.com/apache/airflow/pull/36469#issuecomment-1871430550

   In addition, the is no possible to create DAG ID with this `<img src='x' 
onerror='alert(1)'>` name because it would failed on validation
   
   
https://github.com/apache/airflow/blob/e9ba37bb58da0e3d6739ec063f7160f50487d3b8/airflow/utils/helpers.py#L50-L60
   
   And original regex a bit a different rather than in this PR
   
   
https://github.com/apache/airflow/blob/e9ba37bb58da0e3d6739ec063f7160f50487d3b8/airflow/utils/helpers.py#L42
   
   So it also have a chance that change proposed by this PR rather than fix 
something just breaks someone pipeline


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to