hussein-awala commented on PR #36504: URL: https://github.com/apache/airflow/pull/36504#issuecomment-1872955940
> I expect a long time to go/test all cases . But I love it :). > > But yeah, if we limit it for Connections and Variables for now, that would be cool. I think one general comment here is that not everyone will be able to use those drivers that support async operations I am afraid. There might be various limitations - dependencies, some specific corporate/managed DB configuration that is not supported - so, almost-for-sure - we should have a way to > > a) handle sync access b) fail async access (from triggers) when async access is done and the driver does not support it (?) c) possibly provide a way for Trigger developers to fallback to sync access (following #36492) > > I **think** that cleanest solution we should explicitly recognise sync/async access to Connections/Variables and enable them by a configuration flag for example and have a method/way to check it from Trigger. I have some ideas for testing the async drivers of each database in our CI in a short execution time (I will implement them soon). For this point: > possibly provide a way for Trigger developers to fallback to sync access we have different options, like fallback to sync get when the `create_async_session` raises certain exceptions; in this case we can announce that this feature is only supported with some databases (for the rest, it will fallback to sync) and introduce it as an experimental feature to simplify future changes in the design. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
