potiuk commented on issue #5871: [AIRFLOW-5264] Eslint + npmaudit (depends on [AIRFLOW-5247]) URL: https://github.com/apache/airflow/pull/5871#issuecomment-522867132 Hello @verdan @ashb @tedmiston @r39132 @jmcarp @feng-tao @mik-laj - See the detailed description in the PR. I know you were all involved in #3656 (which has been closed). But after I have done a little experiment, it turned out that eslinting for our .js files + upgrading to latest versions of deps (without known vulnerabilities) as first step can be introduced rather quickly. The change I've done in one evening already fixes all eslint problems AND upgrades to latest dependencies - this removes > 50 vulnerabilities from our code. Vast majority of those fixes is automatically generated by eslint. Even if we have js code to extract from html later - I think what I've done might be a major step in a very good direction. I think if a few people will take a look and test it on their installation / test harnesses they have we might very quickly get this merged into master. I have not been too involved in web UI part so I might have made some basic mistakes and it's worth to take a deeper look (even thought the UI in general seems to work fine after the upgrades/linting). I know for one there was a debate ES5 vs. ES6 in #3656 but it is likely not relevant any more (and especially in Airflow 2.0.0 context). So I went ahead and configured "es6" as target.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
