maiconkkl commented on PR #36437: URL: https://github.com/apache/airflow/pull/36437#issuecomment-1874364103
> I am against this change. > > What is the value of `SECURITY_MANAGER_CLASS` in your scenario? There is something weird because this check was already there before we migrated the code to fab provider, so it should not be a breaking change. We want to make sure whatever class you defined in `SECURITY_MANAGER_CLASS` inherits from `AirflowSecurityManager`. Again, this check was there before so there must be something off somewhere. Hello vincbeck, how are you? Happy New Year!!! When trying to extend AirflowSecurityManager I receive a DeprecationWarning with the following message "Call to deprecated class AirflowSecurityManager. (If you want to override the security manager, you should inherit from `airflow.auth.managers.fab.security_manager.override.FabAirflowSecurityManagerOverride` instead)" And when trying to extend FabAirflowSecurityManagerOverride I receive an Exception with the following message "Your CUSTOM_SECURITY_MANAGER must extend FabAirflowSecurityManagerOverride, not FAB's own security manager." Interpreting what the warnings say, I understand that the AirflowSecurityManager class is becoming obsolete and needs to extend the FabAirflowSecurityManagerOverride class and my change proposes exactly that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
