vincbeck commented on PR #36538: URL: https://github.com/apache/airflow/pull/36538#issuecomment-1874436223
> I have a doubt! Isn't it worth leaving this part of code to keep a compatibility warning? > > ``` > if issubclass(sm_from_config, AirflowSecurityManagerV2): > warnings.warn( > "Please make your custom security manager inherit from " > "FabAirflowSecurityManagerOverride instead of AirflowSecurityManagerV2.", > AirflowProviderDeprecationWarning, > ) > ``` > > This way, whoever uses the class "AirflowSecurityManagerV2" will understand that it is being depreciated and which one they should use. > > It can even be used as a test case too. > > @vincbeck No, this change has been added very recently and is not right. `SECURITY_MANAGER_CLASS ` is a feature of fab provider, as such, if you want to use it, you should inherit from `FabAirflowSecurityManagerOverride`. Plus, `FabAirflowSecurityManagerOverride` is a subclass of `AirflowSecurityManagerV2`, thus by default the deprecation warning is thrown. Plus, `AirflowSecurityManagerV2` is not deprecated at all :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
