DuanWeiFan opened a new pull request, #36565:
URL: https://github.com/apache/airflow/pull/36565
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
Add ability to pause DAGs as separate role from edit.
An updated PR from - #30581
The main update is to make it compatible with
### Use cases
Giving users ability to running DAGs without having the ability to pause it.
Also to prevent users to easily/accidentally suspend DAGs.
### Scopes
- Admin UI
- API
### Changes
- add PATCH method in security manager
- add ACTION_CAN_PAUSE ("can_pause") in security permissions
- set can_pause as part of accessible dag in security manager
- add can_pause dag as part of default USER_PERMISSIONS in security manager
- add function to check if user eligible to pause all/specific dags in
security manager
- disable toggle Pause/Unpause DAG in home page if user is not eligible for
can_pause dag
- disable toggle Pause/Unpause DAG in detail dag page if user is not
eligible for can_pause dag
- disable toggle Unpause DAG when triggered in trigger form if user is not
eligible for can_pause dag
- change access permission to /paused from ACTION_CAN_EDIT to
ACTION_CAN_PAUSE on main view
- change access permission on patch /dags/<dag-id> and /dags from
ACTION_CAN_EDIT to ACTION_CAN_PAUSE on API end point
- add can_pause on DAG Level Role access control documentation
- add migration, append can_pause permission to roles that have can_edit
dag(s) permission
- add tests
closes: #22317
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
