potiuk commented on PR #32572: URL: https://github.com/apache/airflow/pull/32572#issuecomment-1877645245
@ephraimbuddy - if you ask me, we (in community) have absolutely no benchmarks to base things on and also this is sometimes really, really difficult to even know that benchmarking is needed. And it's quite in-feasible to run it on individual PRs, It should rather be run weekly and before releases - because running benchmark test is extreamely time consuming and expensive (and flaky as well so it needs to be repeated a number of times to get some reasonable values) I think - if this one really had majod impact - then it should teach us a lesson and generally (as community) focus our efforts on helping, commenting, encouraging and leadingt to completion the benchmarking proposal - ie. AIP-59: https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-59+Performance+tests+framework cc: @bjankie1 Thiis -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
