dirrao commented on code in PR #36586:
URL: https://github.com/apache/airflow/pull/36586#discussion_r1443646182
##########
airflow/providers/amazon/aws/operators/redshift_data.py:
##########
@@ -121,6 +126,11 @@ def execute(self, context: Context) ->
GetStatementResultResponseTypeDef | str:
"""Execute a statement against Amazon Redshift."""
self.log.info("Executing statement: %s", self.sql)
+ # Set wait_for_completion to False so that it waits for the status in
the deferred task.
Review Comment:
isn't good idea to move this code __init__ function?
We can add warning message saying that we can't set wait_for_completion and
deferrable to True.
##########
airflow/providers/amazon/aws/operators/redshift_data.py:
##########
@@ -87,6 +90,7 @@ def __init__(
aws_conn_id: str = "aws_default",
region: str | None = None,
workgroup_name: str | None = None,
+ deferrable: bool = conf.getboolean("operators", "default_deferrable",
fallback=False),
Review Comment:
can't we use the wait_for_completion parameter alone to deduce the
deferrablity?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
