potiuk commented on code in PR #36537:
URL: https://github.com/apache/airflow/pull/36537#discussion_r1443780984
##########
dev/breeze/src/airflow_breeze/utils/path_utils.py:
##########
@@ -97,7 +97,7 @@ def get_package_setup_metadata_hash() -> str:
return "NOT FOUND"
-def get_sources_setup_metadata_hash(sources: Path) -> str:
+def get_pyproject_toml_hash(sources: Path) -> str:
try:
the_hash = hashlib.new("blake2b")
the_hash.update((sources / "dev" / "breeze" /
"pyproject.toml").read_bytes())
Review Comment:
This is because it is part of `breeze` code. It checks if `breeze` should
self-upgrade. Sometimes whe you run breeze it will self-upgrade - because it
will see that it's own dependencies changed (it's own `pyproject.toml`) and I
have a clever mechanism to check and run it. It's described in
https://github.com/apache/airflow/blob/main/dev/breeze/doc/adr/0010-use-pipx-to-install-breeze.md
I had to update that part because setup.cfg was internaly used in `breeze`
to find the sources of Airflow (and now the file is gone). However I think it
will be better to extract out that change and merge it first in a separate PR -
this way people who will already have `breeze` installed will old check will
fail. I will separate it out (and keep this comment to remember about it).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
