potiuk opened a new pull request, #36647:
URL: https://github.com/apache/airflow/pull/36647
The `graphviz` dependency has been problematic as Airflow required
dependency - especially for ARM-based installations. Graphviz packages require
binary graphviz libraries - which is already a limitation, but they also
require to install graphviz Python bindings to be build and installed. This
does not work for older Linux installation but - more importantly - when you
try to install Graphviz libraries for Python 3.8, 3.9 for ARM M1 MacBooks, the
packages fail to install because Pythonn bindings compilation for M1 can only
work for Python 3.10+.
There is not an easy solution for that except commenting out graphviz
dependency from setup.py, when you want to install Airflow for Python 3.8, 3.9
for MacBook M1.
However Graphviz is really used in two places:
* when you want to render DAGs wia airflow CLI - either to an image or
directly to terminal (for terminals/systems supporting imgcat)
* when you want to rended ER diagram after you modified Airflow models
The latter is a development-only feature, the former is production feature,
however it is a very niche one.
This PR turns rendering of the images in Airflow in optional feature (only
working when graphviz python bindings are installed) and effectively turns
graphviz into an optional extra (and removes it from requirements).
This is not a breaking chnage technically - the CLIs to reder the DAGs is
still there and IF you already have graphviz installed, it will continue
working as it did before. The only problem when it does not work is where you
do not have graphviz installed it will raise an error and inform that you need
it.
Graphviz will remain to be installed for most users:
* the Airflow Image will still contain graphviz library, because it is added
there as extra
* when previous version of Airflow has been installed already, then graphviz
library is already installed there and Airflow will continue working as it did
The only change will be a new installation of new version of Airflow from
the scratch, where graphviz wlll need to be specified as extra or installed
separatley in order to enable DAG rendering option.
Taking into account this behaviour (which only requires to install a
graphviz package), this should not be considered as a breaking change.
Extracted from: #36537
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]