hagope commented on issue #5845: [AIRFLOW-5158] adds google sheets hook
URL: https://github.com/apache/airflow/pull/5845#issuecomment-523140731
 
 
   @nuclearpinguin @mik-laj @milton0825  Thank you for your code review and 
feedback, I've gone fixed up this commit and done the following:
   
   - Added additional code documentation on the methods
   - Moved and renamed the files to the appropriate place
   - Added Unit testing, moved out system test
   - Fixed the issues above which were called out
   
   Please take a look  and let me know if I need any additional changes.
   Also note that I've added [a google sheet system test 
gist](https://gist.github.com/hagope/18b8323e9748e84c72213794f8366ea2) if 
anyone wants to test the hook in their own setup.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to