eladkal commented on code in PR #35714: URL: https://github.com/apache/airflow/pull/35714#discussion_r1447825928
########## airflow/providers/google/cloud/triggers/kubernetes_engine.py: ########## @@ -25,6 +25,7 @@ from google.cloud.container_v1.types import Operation from airflow.exceptions import AirflowProviderDeprecationWarning +from airflow.providers.cncf.kubernetes.callbacks import KubernetesPodOperatorCallback Review Comment: This will not work if user will have combination of newer google provider with older version of k8s provider. I think we better wrap this with some mechanisem that detects this combo and warn the user that he needs to bump k8s provider to use this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
