ferruzzi commented on code in PR #36722:
URL: https://github.com/apache/airflow/pull/36722#discussion_r1448109036
##########
tests/providers/amazon/aws/executors/ecs/test_ecs_executor.py:
##########
@@ -943,8 +944,10 @@ def test_provided_values_override_defaults(self,
assign_subnets):
assert task_kwargs["platformVersion"] == templated_version
- def test_count_can_not_be_modified_by_the_user(self, assign_subnets):
+ @mock.patch.object(EcsHook, "conn")
+ def test_count_can_not_be_modified_by_the_user(self, mock_conn,
assign_subnets):
"""The ``count`` parameter must always be 1; verify that the user can
not override this value."""
+ mock_conn.describe_clusters.return_value = {"clusters": [{"status":
"ACTIVE"}]}
Review Comment:
I dropped the return value line. I was thinking it was more clear with it
in there, but it really only adds clutter to the test. But yeah, the mock
itself has to stay..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
