Lee-W commented on code in PR #36726: URL: https://github.com/apache/airflow/pull/36726#discussion_r1448236087
########## dev/README_RELEASE_AIRFLOW.md: ########## @@ -578,6 +579,45 @@ Checking apache_airflow-2.0.2rc4-py2.py3-none-any.whl.sha512 Checking apache-airflow-2.0.2rc4-source.tar.gz.sha512 ``` +## Reproducible package check + +Airflow build supports reproducible You should check if the packages can be binary-reproduced from the sources. + +Checkout airflow sources and build packages in dist folder: + +```shell script +git checkout X.Y.Zrc1 +export AIRFLOW_REPO_ROOT=$(pwd) +rm -rf dist/* +breeze release-management prepare-airflow-package --package-format both +``` + +That should produce .whl and .tar.gz packages in dist folder. + +Change to the directory where you have the packages from svn: + +```shell script +# First clone the repo if you do not have it +cd .. +[ -d asf-dist ] || svn checkout --depth=immediates https://dist.apache.org/repos/dist asf-dist +svn update --set-depth=infinity asf-dist/dev/airflow + +# Then compare the packages +cd asf-dist/dev/airflow/X.Y.Zrc1 +for i in ${AIRFLOW_REPO_ROOT}/dist/* +do + echo "Checking if $(basename $i) is the same as $i" + diff "$(basename $i)" "$i" && echo "OK" +done Review Comment: Should we make these scripts a breeze command? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
