ashb edited a comment on issue #5743: [AIRFLOW-5088][AIP-24] Persisting 
serialized DAG in DB for webserver scalability
URL: https://github.com/apache/airflow/pull/5743#issuecomment-523394193
 
 
   I'm doing some testing of this. Some comments/possible TODOs:
   
   - [ ] remove `fileloc` from the serialized blob, we already store that in 
the row
   - [x] `_schedule_interval` and `schedule_interval` are both stored. do we 
need both?
   - [ ] remove `default_args` from the dag (we don't need to store them I 
don't think as they are already "applied" when we serialize.
   - [ ] Tasks have `inlets` and `_inlets`, and `outlets` and `_outlets`. We 
probably don't want both versions
   - [x] rename the `dagcached` config setting, it's not _that_ descriptive of 
what we are doing here any more. How about `store_serialized_dags`? 
`serialize_dags`?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to