potiuk commented on issue #36740:
URL: https://github.com/apache/airflow/issues/36740#issuecomment-1891074729
Ah... I know .. my mistake. If you look here - it only changese at which
python version the "2.8.0" alias points to latest one. There is no `python`
used in this if, so the only thing it change is when `latest` becomes aliased
to`2.8.0`.
```
if python == ALLOWED_PYTHON_MAJOR_MINOR_VERSIONS[-1]:
# only tag latest "default" image when we build the latest
allowed python version
if slim_images:
alias_image(
f"{dockerhub_repo}:slim-{airflow_version}",
f"{dockerhub_repo}:slim-latest",
)
else:
alias_image(
f"{dockerhub_repo}:{airflow_version}",
f"{dockerhub_repo}:latest",
)
```
But what **should** be changed is the line before that:
```
if python == DEFAULT_PYTHON_MAJOR_MINOR_VERSION:
alias_image(image_name,
f"{dockerhub_repo}:{airflow_version}")
```
(and similar one in slim image) - > because THERE the
"airflow:2.8.0-python3.8" gets the `airflow:2.8.0` alias - which what it was
about.
I will announce it at devlist that we are delaying it and remove the log in
dockerfile changelog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
