andylamp commented on PR #32867: URL: https://github.com/apache/airflow/pull/32867#issuecomment-1891155867
hi all, sorry for the delay - got a bit of time to get this fixed. @potiuk it turns out that the error FAB front-end was failing was due to the string message having an illegal character. To further reduce any potential formatting (and security?) impact I have reduced the available characters that can comprise a valid `conn_id`. Now the allowed characters are allows alphanumeric plus the symbols #,!,-,_,.,:,\,/ and () requiring at least one match. To allow a bit of freedom, I have put a parameter to configure the max length allowed and by default it is set to the same length keys should have, namely 250. All tests that I tried pass and the connection error pop-up successfully.  Happy for any comments regarding this but I think it is finally complete :-). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
