This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 708619256c Remove optimization to install wheel pacakges for affected
providers (#36825)
708619256c is described below
commit 708619256cd57a4f80a9cd650e22c2c6d05124b6
Author: Jarek Potiuk <[email protected]>
AuthorDate: Wed Jan 17 00:24:56 2024 +0100
Remove optimization to install wheel pacakges for affected providers
(#36825)
When building wheel providers took a lot of time (12 minutes) there
was an optimisation implemented to only build the affected providers
and in this case we could not run verification, because having only
subset of providers would generate errors during imports.
However, changes to make our package bulds reproducible with flit #35693
also improve building time for provider packages (all of them are
built under 1 minute) and .whl installation had always been rather
quick - so we can remove the optimisation now, because side effect
of it that in some cases (like #36799) it caused the backwards
compatibility check succeed - and subsequently continue failing in
main canary build.
---
.github/workflows/ci.yml | 35 +++--------------------------------
1 file changed, 3 insertions(+), 32 deletions(-)
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 9b02fc3446..19b6d16471 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -834,12 +834,10 @@ jobs:
run: >
breeze release-management prepare-provider-documentation
--include-not-ready-providers
--non-interactive
- ${{ needs.build-info.outputs.affected-providers-list-as-string }}
- name: "Prepare provider packages: wheel"
run: >
breeze release-management prepare-provider-packages
--include-not-ready-providers
- --version-suffix-for-pypi dev0
- --package-format wheel ${{
needs.build-info.outputs.affected-providers-list-as-string }}
+ --version-suffix-for-pypi dev0 --package-format wheel
- name: "Prepare airflow package: wheel"
run: breeze release-management prepare-airflow-package
--version-suffix-for-pypi dev0
- name: "Verify wheel packages with twine"
@@ -862,25 +860,11 @@ jobs:
--airflow-constraints-reference default
--providers-constraints-location
/files/constraints-${{env.PYTHON_MAJOR_MINOR_VERSION}}/constraints-source-providers-${{env.PYTHON_MAJOR_MINOR_VERSION}}.txt
- if: needs.build-info.outputs.affected-providers-list-as-string == ''
- env:
- AIRFLOW_SKIP_CONSTRAINTS: "${{
needs.build-info.outputs.upgrade-to-newer-dependencies }}"
- - name: "Install affected provider packages and airflow via wheel files"
- run: >
- breeze release-management install-provider-packages
- --use-packages-from-dist
- --package-format wheel
- --use-airflow-version wheel
- --airflow-constraints-reference default
- --providers-constraints-location
-
/files/constraints-${{env.PYTHON_MAJOR_MINOR_VERSION}}/constraints-source-providers-${{env.PYTHON_MAJOR_MINOR_VERSION}}.txt
- if: needs.build-info.outputs.affected-providers-list-as-string != ''
env:
AIRFLOW_SKIP_CONSTRAINTS: "${{
needs.build-info.outputs.upgrade-to-newer-dependencies }}"
- name: "Prepare airflow package: wheel without suffix and skipping the
tag check"
run: >
- breeze release-management prepare-provider-packages --skip-tag-check
- --package-format wheel ${{
needs.build-info.outputs.affected-providers-list-as-string }}
+ breeze release-management prepare-provider-packages --skip-tag-check
--package-format wheel
prepare-install-provider-packages-sdist:
timeout-minutes: 80
@@ -975,7 +959,7 @@ jobs:
- name: "Prepare provider packages: wheel"
run: >
breeze release-management prepare-provider-packages
--include-not-ready-providers
- --package-format wheel ${{
needs.build-info.outputs.affected-providers-list-as-string }}
+ --package-format wheel
- name: >
Remove incompatible Airflow
${{matrix.airflow-version}}:Python ${{matrix.python-version}}
provider packages
@@ -996,19 +980,6 @@ jobs:
--use-airflow-version wheel
--airflow-constraints-reference
constraints-${{matrix.airflow-version}}
--providers-skip-constraints
- if: needs.build-info.outputs.affected-providers-list-as-string == ''
- - name: >
- Install affected provider packages and airflow on
- Airflow ${{matrix.airflow-version}}:Python ${{matrix.python-version}}
- run: >
- breeze release-management install-provider-packages
- --use-packages-from-dist
- --package-format wheel
- --use-airflow-version wheel
- --airflow-constraints-reference
constraints-${{matrix.airflow-version}}
- --providers-skip-constraints
- --run-in-parallel
- if: needs.build-info.outputs.affected-providers-list-as-string != ''
test-airflow-release-commands:
timeout-minutes: 80