Taragolis commented on code in PR #36831:
URL: https://github.com/apache/airflow/pull/36831#discussion_r1454889462
##########
airflow/providers/google/cloud/links/dataproc.py:
##########
@@ -76,10 +80,6 @@ class DataprocLink(BaseOperatorLink):
This link is deprecated.
"""
- warnings.warn(
- "This DataprocLink is deprecated.",
- AirflowProviderDeprecationWarning,
- )
Review Comment:
And this is breaks Static Checks 🙄
```console
Found 3 errors in providers
Error: The `airflow.providers.google.cloud.operators.dataproc` module in
operators list in airflow/providers/google/provider.yaml is deprecated with
this message: 'This DataprocLink is deprecated.'.
How to fix it: Please remove it from provider.yaml and replace it with the
new module. If you see warnings in classes - fix the classes so that they are
not raising Deprecation Warnings when module is imported.
Error: The `airflow.providers.google.cloud.operators.dataproc` module in
operators list in airflow/providers/google/provider.yaml is deprecated with
this message: 'This DataprocLink is deprecated.'.
How to fix it: Please remove it from provider.yaml and replace it with the
new module. If you see warnings in classes - fix the classes so that they are
not raising Deprecation Warnings when module is imported.
Error: The `airflow.providers.google.cloud.operators.dataproc` module in
operators list in airflow/providers/google/provider.yaml is deprecated with
this message: 'This DataprocLink is deprecated.'.
How to fix it: Please remove it from provider.yaml and replace it with the
new module. If you see warnings in classes - fix the classes so that they are
not raising Deprecation Warnings when module is imported.
Error 1 returned
```
This links are deprecated but still defined in Operators, e.g. in
[`DataprocJobBaseOperator`](https://github.com/apache/airflow/blob/9f3cb1f00e1f24ba8158f3805c69741ef38bbc7d/airflow/providers/google/cloud/operators/dataproc.py#L1108)
So seems like this Links should not be deprecated or operators should not
use this links but not both
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
