ashb commented on a change in pull request #5873: [AIRFLOW-5269] Reuse session 
in Scheduler Job from health endpoint
URL: https://github.com/apache/airflow/pull/5873#discussion_r316250074
 
 

 ##########
 File path: airflow/jobs/base_job.py
 ##########
 @@ -93,7 +93,7 @@ def __init__(
 
     @classmethod
     @provide_session
-    def most_recent_job(cls, session: Session) -> Optional['BaseJob']:
+    def most_recent_job(cls, session=None) -> Optional['BaseJob']:
 
 Review comment:
   Did we need to change this to `None`? This is  quirk between type checkers 
and docs here. :/

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to