syedahsn commented on code in PR #36586:
URL: https://github.com/apache/airflow/pull/36586#discussion_r1456412652
##########
airflow/providers/amazon/aws/hooks/redshift_data.py:
##########
@@ -201,3 +216,54 @@ def get_table_primary_key(
break
return pk_columns or None
+
+ async def check_query_is_finished_async(
Review Comment:
I have a general question about this function versus the
`check_query_is_finished`. Why is their behaviour so different, if both are
doing the same thing? The async version seems to include a loop that runs until
the query stops running, whereas the sync version just does a check to see the
current status. I think when we write functions like this (i.e. async versions
of sync functions), we should try to keep the behaviour as similar as possible
or rename the new function if it does something significantly different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
