nuclearpinguin commented on a change in pull request #5877: [AIRFLOW-5275] Add
support for template parameters in DataprocWorkflowTemplateInstantiateOperator
URL: https://github.com/apache/airflow/pull/5877#discussion_r316253848
##########
File path: airflow/contrib/operators/dataproc_operator.py
##########
@@ -1108,17 +1114,17 @@ def __init__(self, template_id, *args, **kwargs):
super().__init__(*args, **kwargs)
self.template_id = template_id
- def start(self):
+ def start(self, parameters):
Review comment:
If would be better to add `self.parameters = parameters` in `__init__`
because otherwise it will not work because `start` method is called by
`execute` in `DataprocOperationBaseOperator`:
```python
def execute(self, context):
self.hook.wait(self.start())
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
