Anush008 commented on PR #36805: URL: https://github.com/apache/airflow/pull/36805#issuecomment-1902053348
> I think that some of the hook tests are not needed since there is no wrapper for the client methods in the hook, you call them from the client and you check if they are called. Same for the hook integration tests. I don't have a strong opinion on this, let's wait for the other reviews. Right. There were some wrapper methods before [this](https://github.com/apache/airflow/pull/36805/commits/bc880993c8afe7914dc17a84d06e5f8613f0cbae) commit. But then they seemed redundant as the caller can very well get the client through `get_conn()` and have access to all the methods. So I updated the mock hook tests accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
